feat(pm_list): add required fields for sofort #3192

AkshayaFoiger · 2023-12-21T13:54:11Z

Type of Change

Description

Resolves #3704

Test Cases

Create a sofort payment with mollie with empty payment method object. The payment should succeed.

{
  "amount": 1000,
  "currency": "EUR",
  "confirm": true,
  "capture_method": "automatic",
  "capture_on": "2022-09-10T10:11:12Z",
  "amount_to_capture": 1000,
  "customer_id": "StripeCustomer",
  "email": "[email protected]",
  "name": "John Doe",
  "phone": "999999999",
  "phone_country_code": "+65",
  "description": "Its my first payment request",
  "authentication_type": "three_ds",
  "return_url": "https://google.com",
  "statement_descriptor_name": "joseph",
  "statement_descriptor_suffix": "JS",
  "payment_method": "bank_redirect",
  "payment_method_type": "sofort",
  "payment_method_data": {
    "bank_redirect": {
      "sofort": {
      }
    }
  }
}

Must be tested for each of this connectors

Adyen

None

ACI

Required fields: 
     payment_method_data.bank_redirect.sofort.country

GlobalPayments

Required fields: 
    billing.address.country

Mollie

None

Nuvie

Required fields: 
     email
     billing.address.first_name
     billing.address.last_name
     billing.address.country

Paypal

Required fields: 
     payment_method_data.bank_redirect.sofort.billing_details.billing_name
     payment_method_data.bank_redirect.sofort.country

Shift4

None

Stripe

Required fields for mandates
     payment_method_data.bank_redirect.sofort.billing_details.billing_name
     payment_method_data.bank_redirect.sofort.billing_details.email

Trustpay

Required fields: 
     billing.address.first_name
     billing.address.line1
     billing.address.city
     billing.address.zip
     billing.address.country

Nexinets

None

-> Create a payment with confirm false

-> list payment methods, with client secret and publishable key

curl --location 'http://localhost:8080/account/payment_methods?client_secret={{client_secret}}' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key:{{api_key}}' \
--data ''

Required fields must be populated, according to the connector

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

crates/router/src/configs/defaults.rs

config/config.example.toml

crates/router/src/connector/adyen/transformers.rs

crates/router/src/connector/paypal/transformers.rs

prasunna09 · 2024-01-12T13:42:48Z

crates/router/src/connector/stripe/transformers.rs

+    preferred_language: Option<String>,
    #[serde(rename = "payment_method_data[sofort][country]")]
-    country: api_enums::CountryAlpha2,
+    country: Option<api_enums::CountryAlpha2>,


is this not mandatory??

Country is not mandatory for stripe sofort

as we checked , it is mandatory. make the necessary changes

prasunna09 · 2024-01-12T13:43:19Z

crates/router/src/connector/stripe/transformers.rs

+            } => Ok(get_stripe_sepa_dd_mandate_billing_details(
+                billing_details,
+                is_customer_initiated_mandate_payment,
+            )?),


why are ideal changes done in sofort pr?

Recurring pay for Ideal and Sofort in stripe happens through SEPA Direct Debit payments. Therefore both requires same request body resulting in repeated code, hence I removed the redundancy by moving it into a function get_stripe_sepa_dd_mandate_billing_details

can u please add the same comment in code to avoid confusion in future

Co-authored-by: Prasunna Soppa <[email protected]>

prasunna09 · 2024-01-18T10:48:41Z

crates/router/src/connector/stripe/transformers.rs

+    preferred_language: Option<String>,
    #[serde(rename = "payment_method_data[sofort][country]")]
-    country: api_enums::CountryAlpha2,
+    country: Option<api_enums::CountryAlpha2>,


as we checked , it is mandatory. make the necessary changes

prasunna09 · 2024-01-18T10:49:24Z

crates/router/src/connector/stripe/transformers.rs

+            } => Ok(get_stripe_sepa_dd_mandate_billing_details(
+                billing_details,
+                is_customer_initiated_mandate_payment,
+            )?),


can u please add the same comment in code to avoid confusion in future

crates/router/src/configs/defaults.rs

Co-authored-by: Prasunna Soppa <[email protected]>

AkshayaFoiger added 5 commits December 21, 2023 13:31

add dynamic fields for sofort aci

bd1c1dc

add dynamic field changes for sofort aci

b3d0f99

add dynamic field changes for sofort aci

dd67fee

add globalpay and mollie dynamic fields for sofort

0bd5824

add dynamic fields for sofort

588c6b3

AkshayaFoiger added A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes labels Dec 21, 2023

AkshayaFoiger self-assigned this Dec 21, 2023

AkshayaFoiger requested review from a team as code owners December 21, 2023 13:54

AkshayaFoiger changed the title ~~Dynamic field/sofort~~ feat(pm_list): add required fields for sofort Dec 21, 2023

github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 21, 2023

chore: run formatter

8679744

github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 21, 2023

hyperswitch-bot bot and others added 3 commits December 21, 2023 14:03

docs(openapi): re-generate OpenAPI specification

eb36df4

add mandate req field for stripe sofort

e790955

chore: run formatter

678eb53

prasunna09 requested changes Jan 8, 2024

View reviewed changes

crates/router/src/configs/defaults.rs Outdated Show resolved Hide resolved

AkshayaFoiger and others added 2 commits January 9, 2024 11:15

Merge branch 'main' into dynamic_field/sofort

4c4e0c0

make fields manditory

bd59a2e

AkshayaFoiger changed the base branch from main to dynamic_field/ideal January 9, 2024 07:11

AkshayaFoiger requested review from a team as code owners January 9, 2024 07:11

AkshayaFoiger changed the base branch from dynamic_field/ideal to main January 9, 2024 07:13

AkshayaFoiger changed the base branch from main to dynamic_field/ideal January 9, 2024 07:17

AkshayaFoiger changed the base branch from dynamic_field/ideal to main January 9, 2024 07:17

correct field path

28cb2cd

prasunna09 requested changes Jan 12, 2024

View reviewed changes

AkshayaFoiger and others added 5 commits January 12, 2024 19:41

Update crates/router/src/connector/paypal/transformers.rs

17ee23d

Co-authored-by: Prasunna Soppa <[email protected]>

Merge branch 'main' into dynamic_field/sofort

9bc80d4

fix clippy error

1b7c138

fix clippy error

2bc92a4

chore: run formatter

1717524

prasunna09 requested changes Jan 18, 2024

View reviewed changes

prasunna09 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Jan 18, 2024

resolve comment: make stripe country req

6d65743

prasunna09 requested changes Jan 18, 2024

View reviewed changes

crates/router/src/configs/defaults.rs Outdated Show resolved Hide resolved

AkshayaFoiger and others added 4 commits January 18, 2024 16:32

Update crates/router/src/configs/defaults.rs

cb87d75

Co-authored-by: Prasunna Soppa <[email protected]>

add comment

ea7eb37

add re field for stripe

9c0af54

chore: run formatter

5821804

prasunna09 previously approved these changes Jan 18, 2024

View reviewed changes

prasunna09 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Jan 18, 2024

ArjunKarthik previously approved these changes Jan 24, 2024

View reviewed changes

Merge branch 'main' into dynamic_field/sofort

c0ccd99

AkshayaFoiger dismissed stale reviews from ArjunKarthik and prasunna09 via c0ccd99 January 25, 2024 07:12

ArjunKarthik approved these changes Jan 25, 2024

View reviewed changes

prasunna09 approved these changes Jan 25, 2024

View reviewed changes

Chethan-rao approved these changes Jan 29, 2024

View reviewed changes

Gnanasundari24 added this pull request to the merge queue Jan 30, 2024

Merged via the queue into main with commit 3d55e3b Jan 30, 2024
10 checks passed

Gnanasundari24 deleted the dynamic_field/sofort branch January 30, 2024 09:23

pixincreate removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pm_list): add required fields for sofort #3192

feat(pm_list): add required fields for sofort #3192

AkshayaFoiger commented Dec 21, 2023 •

edited

Loading

prasunna09 Jan 12, 2024

AkshayaFoiger Jan 12, 2024 •

edited

Loading

prasunna09 Jan 18, 2024

prasunna09 Jan 12, 2024

AkshayaFoiger Jan 12, 2024 •

edited

Loading

prasunna09 Jan 18, 2024

prasunna09 Jan 18, 2024

prasunna09 Jan 18, 2024

feat(pm_list): add required fields for sofort #3192

feat(pm_list): add required fields for sofort #3192

Conversation

AkshayaFoiger commented Dec 21, 2023 • edited Loading

Type of Change

Description

Test Cases

Checklist

prasunna09 Jan 12, 2024

Choose a reason for hiding this comment

AkshayaFoiger Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

prasunna09 Jan 18, 2024

Choose a reason for hiding this comment

prasunna09 Jan 12, 2024

Choose a reason for hiding this comment

AkshayaFoiger Jan 12, 2024 • edited Loading

Choose a reason for hiding this comment

prasunna09 Jan 18, 2024

Choose a reason for hiding this comment

prasunna09 Jan 18, 2024

Choose a reason for hiding this comment

prasunna09 Jan 18, 2024

Choose a reason for hiding this comment

AkshayaFoiger commented Dec 21, 2023 •

edited

Loading

AkshayaFoiger Jan 12, 2024 •

edited

Loading

AkshayaFoiger Jan 12, 2024 •

edited

Loading