feat(users): Added get role from jwt api #3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racnan
added
C-feature
apoorvdixit88
previously approved these changes
Jan 18, 2024
apoorvdixit88
previously approved these changes
Jan 18, 2024
ThisIsMani
previously approved these changes
Jan 18, 2024
Narayanbhat166
previously approved these changes
Jan 18, 2024
vspecky
requested changes
Jan 18, 2024
crates/router/src/utils/user_role.rs
Outdated
| impl TryFrom<&Permission> for user_role_api::Permission { | ||
| type Error = (); | ||
| fn try_from(value: &Permission) -> Result<Self, Self::Error> { | ||
| impl From<&Permission> for user_role_api::Permission { |
There was a problem hiding this comment.
Why do we need to implement conversion on &T instead of T?
racnan
dismissed stale reviews from Narayanbhat166, ThisIsMani, and apoorvdixit88
via
5652b9f
vspecky
approved these changes
Jan 18, 2024
apoorvdixit88
approved these changes
Jan 18, 2024
ThisIsMani
approved these changes
Jan 18, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 18, 2024
* 'main' of github.com:juspay/hyperswitch: feat(users): Added get role from jwt api (#3385) feat(users): Add `preferred_merchant_id` column and update user details API (#3373) chore(version): 2024.01.18.1 refactor(core): add locker config to enable or disable locker (#3352) fix(connector): [Cashtocode] update amount from i64 to f64 in webhook payload (#3382) fix(metrics): Add TASKS_ADDED_COUNT and TASKS_RESET_COUNT metrics in router scheduler flow (#3189) fix(connector): Trustpay zen error mapping (#3255) fix(user): fetch profile_id for sample data (#3358) refactor(connector): [Volt] Refactor Payments and Refunds Webhooks (#3377) chore(version): 2024.01.18.0
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added API to get list of permission user has.
Additional Changes
Motivation and Context
Required for hyperswitch control centre
How did you test it?
Above API should give an array of permission.
All roles and their permission can be found here.
Example response,
Checklist
cargo +nightly fmt --allcargo clippy