Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connector): added amount conversion framework for stax #6244

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

amitroy-thedev
Copy link
Contributor

@amitroy-thedev amitroy-thedev commented Oct 6, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

closes #6021

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@amitroy-thedev amitroy-thedev requested review from a team as code owners October 6, 2024 11:36
Copy link

semanticdiff-com bot commented Oct 6, 2024

Review changes with SemanticDiff.

Analyzed 4 of 4 files.

Overall, the semantic diff is 38% smaller than the GitHub diff.

Filename Status
✔️ crates/router/tests/connectors/stax.rs 51.88% smaller
✔️ crates/router/src/types/api.rs 79.34% smaller
✔️ crates/hyperswitch_connectors/src/connectors/stax.rs 26.29% smaller
✔️ crates/hyperswitch_connectors/src/connectors/stax/transformers.rs 46.17% smaller

@gorakhnathy7 gorakhnathy7 added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 15, 2024
@deepanshu-iiitu
Copy link
Contributor

Hi @amitroy-thedev
Your code is not compiling. Please use cargo build to resolve all the errors.

@amitroy-thedev
Copy link
Contributor Author

@deepanshu-iiitu I'm getting this error error: failed to run custom build command for openssl-sys v0.9.103 and i'm unable to fix it would you help me to fix it

@deepanshu-iiitu
Copy link
Contributor

Hey @amitroy-thedev What is the OS that you are using. Also are you getting this error during cargo run?

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Oct 22, 2024
@amitroy-thedev
Copy link
Contributor Author

@deepanshu-iiitu Windows 11.. Yes I'm getting the error during cargo run

crates/hyperswitch_connectors/src/connectors/stax.rs Outdated Show resolved Hide resolved
crates/hyperswitch_connectors/src/connectors/stax.rs Outdated Show resolved Hide resolved
crates/hyperswitch_connectors/src/connectors/stax.rs Outdated Show resolved Hide resolved
crates/hyperswitch_connectors/src/connectors/stax.rs Outdated Show resolved Hide resolved
@deepanshu-iiitu
Copy link
Contributor

Hey @amitroy-thedev
Could you please post your compilation issue in our discord channel
https://discord.com/channels/1060451405535649813/1070640021968785408
Someone from the team will help regarding it.

@deepanshu-iiitu
Copy link
Contributor

Hey @amitroy-thedev
Can you please work on the above suggested changes.
You can also refer to this pr #6428

@deepanshu-iiitu
Copy link
Contributor

Hey @amitroy-thedev
Could you please post your compilation issue in our discord channel
https://discord.com/channels/1060451405535649813/1070640021968785408
Someone from the team will help regarding it.
The code is still not compiling can you refer to this pr and do the changes #6428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [STAX] Add amount conversion framework to Stax
5 participants