-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): Move organization_id to request header from request body for v2 #6277
Conversation
Review changes with SemanticDiff. Analyzed 10 of 10 files. Overall, the semantic diff is 9% smaller than the GitHub diff.
|
441f450
to
916383a
Compare
Co-authored-by: Narayan Bhat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dashboard changes look fine.
84899fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for dashboard changes.
@Anurag-05-prog Run the v2 cypress test for organization and add the screenshot |
@Gnanasundari24 Added |
72a9784
Type of Change
Description
For create_merchant request organization_id is currently being passed in request body. Moved it to request header
Additional Changes
Motivation and Context
How did you test it?
1a. Correct Request
1b. Response
2a. Non-existant Org-ID Request
2b. Response
3a. Invalid Org_id request
3b. Response
Cypress Screenshot:
Checklist
cargo +nightly fmt --all
cargo clippy