-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add macro to generate ToEncryptable trait #6313
Open
dracarys18
wants to merge
16
commits into
main
Choose a base branch
from
batch_encrypt_decrypt_macro
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Oct 14, 2024
…switch into batch_encrypt_decrypt_macro
ArjunKarthik
previously approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good to me!
Co-authored-by: Sanchith Hegde <[email protected]>
SanchithHegde
previously approved these changes
Oct 15, 2024
…switch into batch_encrypt_decrypt_macro
Co-authored-by: Sanchith Hegde <[email protected]>
ArjunKarthik
previously approved these changes
Oct 25, 2024
sai-harsha-vardhan
previously approved these changes
Oct 25, 2024
dracarys18
dismissed stale reviews from sai-harsha-vardhan and ArjunKarthik
via
October 25, 2024 06:46
c3624c8
ArjunKarthik
approved these changes
Oct 25, 2024
sai-harsha-vardhan
approved these changes
Oct 25, 2024
SanchithHegde
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds a macro to generate ToEncryptable trait on different types
Motivation and Context
This PR removes the effort of repetitively implementing ToEncryptable trait which is used for batch encryption/decryption in the encryption service by adding a macro which generates code upon deriving it
How did you test it?
THIS CANNOT BE TESTED ON SANDBOX
Checklist
cargo +nightly fmt --all
cargo clippy