refactor(connector): add amount conversion framework to Riskified #6359
Conversation
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 29% smaller than the GitHub diff.
|
gorakhnathy7
added
the
hacktoberfest
swangi-kumari
added
A-connector-integration
|
Hi @Sidharth-Singh10 , Thanks for the PR, There has been some correction in the issue, Actually Riskified accepts amount as Major unit(ex : Dollars in US), could you please make the same changes with amount type as Major Unit. Please let us know if need any other info. Thanks |
|
Hi @srujanchikke, so the change is to replace |
Yes, you're right |
|
@srujanchikke, I’ve made the requested changes. |
| cart_token: payment_data.attempt_id.clone(), | ||
| line_items: payment_data | ||
| .request | ||
| .get_order_details()? | ||
| .iter() | ||
| .map(|order_detail| LineItem { | ||
| price: order_detail.amount, | ||
| price: StringMajorUnit::new(order_detail.amount.to_string()), |
There was a problem hiding this comment.
I made the requested changes at other places.
but here the amount' is field of OrderDetailsWithAmount struct which is i64, I am unable to grasp how to use it directly.
| @@ -156,14 +176,14 @@ impl TryFrom<&frm_types::FrmCheckoutRouterData> for RiskifiedPaymentsCheckoutReq | |||
| created_at: common_utils::date_time::now(), | |||
| updated_at: common_utils::date_time::now(), | |||
| gateway: payment_data.request.gateway.clone(), | |||
| total_price: payment_data.request.amount, | |||
| total_price: StringMajorUnit::new(payment_data.request.amount.to_string()), | |||
There was a problem hiding this comment.
| total_price: StringMajorUnit::new(payment_data.request.amount.to_string()), | |
| total_price: payment.amount.clone(), |
| let amount = convert_amount( | ||
| self.amount_converter, | ||
| MinorUnit::new(req.request.amount), | ||
| req.request | ||
| .currency | ||
| .ok_or(errors::ConnectorError::MissingRequiredField { | ||
| field_name: "currency", | ||
| })?, | ||
| )?; |
There was a problem hiding this comment.
Similar change needs to be done wherever amount is being used like FrmTransactionRouterData .
Type of Change
Description
This PR does amount conversion changes for Riskified Connector and it accepts the amount in MinorUnit
Additional Changes
Motivation and Context
Fixes #6139
Checklist
cargo +nightly fmt --allcargo clippy