Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_methods): refactor customer payment methods list v2 code to follow better code practices #6433

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

refactor(payment_methods): refactor customer payment methods list v2 code to follow better code practices #6433

wants to merge 14 commits into from

Commits on Oct 24, 2024

  1. refactor(profile): add should_collect_cvv_during_payment field

    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1ea8323 View commit details
    Browse the repository at this point in the history

  2. refactor(api_models): improve doc comments for `is_network_tokenizati… 

    …on_enabled` field in profile types
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    01a9445 View commit details
    Browse the repository at this point in the history

  3. refactor(payment_methods): rename business_profile to profile in … 

    …`SavedPMLPaymentsInfo`
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    763cfa9 View commit details
    Browse the repository at this point in the history

  4. refactor(payment_methods): rename requires_cvv to `collect_cvv_duri… 

    …ng_payment` in `SavedPMLPaymentsInfo` and populate it from profile
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bf04f19 View commit details
    Browse the repository at this point in the history

  5. refactor(payment_methods): accept merchant account by reference inste… 

    …ad of value
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a24617f View commit details
    Browse the repository at this point in the history

  6. refactor(hyperswitch_domain_models): update variants toggling a field… 

    … during update to be required fields
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9c02f4d View commit details
    Browse the repository at this point in the history

  7. refactor: pass profile to form_payments_info() instead of fetching … 

    …it within `form_payments_info()`
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    40459cc View commit details
    Browse the repository at this point in the history

  8. refactor(payment_methods): move PaymentsMandateReference from `rout… 

    …er` crate to `diesel_models` crate
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6ffd4ff View commit details
    Browse the repository at this point in the history

  9. refactor(payment_methods): use concrete type instead of `serde_json::… 

    …Value` for `connector_mandate_details` field
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5aa9651 View commit details
    Browse the repository at this point in the history

  10. refactor(payment_methods): refactor get_mca_status() function to re… 

    …move database call happening in a loop
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c86426c View commit details
    Browse the repository at this point in the history

  11. refactor(payment_methods): use serialize_and_set_key_with_expiry() … 

    …when storing payment method token in Redis
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bce9819 View commit details
    Browse the repository at this point in the history

  12. refactor(payment_methods): replace usages of `create_payment_method()… 

    …` with a correct `apply_changeset()` implementation
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1735421 View commit details
    Browse the repository at this point in the history

  13. refactor(payment_methods): drop column metadata in v2 code since it… 

    … not actively being used in v1

There does not seem to be any useful information in this column in any of our hosted environments either.
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a222400 View commit details
    Browse the repository at this point in the history

  14. refactor(payment_methods): use collect() to collect Vec<Result> t… 

    …o `Result<Vec, _>`
    @SanchithHegde
    SanchithHegde committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c086430 View commit details
    Browse the repository at this point in the history