fix: remove change_reason from config_version

crates/context_aware_config/src/api/context/handlers.rs

@@ -98,7 +98,6 @@ async fn put_handler(
             let version_id = add_config_version(
                 &state,
                 tags,
-                description,
                 req_change_reason,
                 transaction_conn,
                 &schema_name,
@@ -158,7 +157,6 @@ async fn update_override_handler(
             let version_id = add_config_version(
                 &state,
                 tags,
-                description.clone(),
                 req_change_reason.clone(),
                 transaction_conn,
                 &schema_name,
@@ -219,7 +217,6 @@ async fn move_handler(
             let version_id = add_config_version(
                 &state,
                 tags,
-                move_response.description.clone(),
                 move_response.change_reason.clone(),
                 transaction_conn,
                 &schema_name,
@@ -384,17 +381,15 @@ async fn delete_context_handler(
     let tags = parse_config_tags(custom_headers.config_tags)?;
     let version_id =
         db_conn.transaction::<_, superposition::AppError, _>(|transaction_conn| {
-            let context = contexts_table
+            contexts_table
                 .filter(context_id.eq(ctx_id.clone()))
                 .schema_name(&schema_name)
                 .first::<Context>(transaction_conn)?;
             operations::delete(ctx_id.clone(), &user, transaction_conn, &schema_name)?;
-            let description = context.description;
             let change_reason = format!("Deleted context by {}", user.username);
             let version_id = add_config_version(
                 &state,
                 tags,
-                description,
                 change_reason,
                 transaction_conn,
                 &schema_name,
@@ -548,14 +543,11 @@ async fn bulk_operations(
                 }
             }
 
-            let combined_description = all_descriptions.join(",");
-
             let combined_change_reasons = all_change_reasons.join(",");
 
             let version_id = add_config_version(
                 &state,
                 tags,
-                combined_description,
                 combined_change_reasons,
                 transaction_conn,
                 &schema_name,
@@ -647,9 +639,8 @@ async fn weight_recompute(
                         db_error!(err)
                     })?;
             }
-            let description = "Recomputed weight".to_string();
             let change_reason = "Recomputed weight".to_string();
-            let version_id = add_config_version(&state, tags, description, change_reason, transaction_conn, &schema_name)?;
+            let version_id = add_config_version(&state, tags, change_reason, transaction_conn, &schema_name)?;
             Ok(version_id)
         })?;
     #[cfg(feature = "high-performance-mode")]

crates/context_aware_config/src/api/default_config/handlers.rs

@@ -22,7 +22,7 @@ use superposition_types::{
         models::cac::{self as models, Context, DefaultConfig},
         schema::{self, contexts::dsl::contexts, default_configs::dsl},
     },
-    result as superposition, DBConnection, FunctionNameEnum, PaginatedResponse, User,
+    result as superposition, DBConnection, PaginatedResponse, User,
 };
 
 #[cfg(feature = "high-performance-mode")]
@@ -134,7 +134,6 @@ async fn create_default_config(
             let version_id = add_config_version(
                 &state,
                 tags,
-                description,
                 change_reason,
                 transaction_conn,
                 &schema_name,
@@ -183,10 +182,6 @@ async fn update_default_config(
             }
         })?;
 
-    let description = req
-        .description
-        .clone()
-        .unwrap_or_else(|| existing.description.clone());
     let change_reason = req.change_reason.clone();
 
     let value = req.value.clone().unwrap_or_else(|| existing.value.clone());
@@ -215,11 +210,10 @@ async fn update_default_config(
         ));
     }
 
-    let function_name = match req.function_name.clone() {
-        Some(FunctionNameEnum::Name(func_name)) => Some(func_name),
-        Some(FunctionNameEnum::Remove) => None,
-        None => existing.function_name.clone(),
-    };
+    let function_name = req
+        .function_name
+        .clone()
+        .map_or_else(|| existing.function_name.clone(), |f| f.to_option());
 
     if let Err(e) = validate_and_get_function_code(
         &mut conn,
@@ -247,7 +241,6 @@ async fn update_default_config(
             let version_id = add_config_version(
                 &state,
                 tags.clone(),
-                description,
                 change_reason,
                 transaction_conn,
                 &schema_name,
@@ -384,8 +377,6 @@ async fn delete(
     let key: String = path.into_inner().into();
     let mut version_id = 0;
 
-    let default_config_row = fetch_default_key(&key, &mut conn, &schema_name)?;
-
     let context_ids = get_key_usage_context_ids(&key, &mut conn, &schema_name)
         .map_err(|_| unexpected_error!("Something went wrong"))?;
     if context_ids.is_empty() {
@@ -400,7 +391,6 @@ async fn delete(
                     .schema_name(&schema_name)
                     .execute(transaction_conn)?;
 
-                let description = default_config_row.description;
                 let change_reason = format!("Context Deleted by {}", user.get_email());
 
                 let deleted_row =
@@ -415,7 +405,6 @@ async fn delete(
                         version_id = add_config_version(
                             &state,
                             tags,
-                            description,
                             change_reason,
                             transaction_conn,
                             &schema_name,

crates/context_aware_config/src/api/default_config/types.rs

@@ -3,7 +3,7 @@ use diesel::AsChangeset;
 use serde::{Deserialize, Deserializer};
 use serde_json::{Map, Value};
 use superposition_types::{
-    database::schema::default_configs, FunctionNameEnum, RegexEnum,
+    api::function::FunctionNameEnum, database::schema::default_configs, RegexEnum,
 };
 
 #[derive(Debug, Deserialize)]

crates/context_aware_config/src/api/dimension/handlers.rs

@@ -213,9 +213,7 @@ async fn update(
                         .execute(transaction_conn)?
                 };
             }
-            let update_position =
-                Position::try_from(new_position).map_err(|err| unexpected_error!(err))?;
-            update_req.position = Some(update_position);
+            update_req.position = Some(new_position.clone());
             diesel::update(dimensions)
                 .filter(dsl::dimension.eq(name))
                 .set((

crates/context_aware_config/src/api/dimension/types.rs

@@ -3,7 +3,7 @@ use diesel::AsChangeset;
 use serde::Deserialize;
 use serde_json::Value;
 use superposition_types::{
-    database::schema::dimensions, FunctionNameEnum, Position, RegexEnum,
+    api::function::FunctionNameEnum, database::schema::dimensions, Position, RegexEnum,
 };
 
 #[derive(Debug, Deserialize)]

crates/context_aware_config/src/helpers.rs

@@ -294,7 +294,6 @@ pub fn add_config_version(
     state: &Data<AppState>,
     tags: Option<Vec<String>>,
     description: String,
-    change_reason: String,
     db_conn: &mut DBConnection,
     schema_name: &SchemaName,
 ) -> superposition::Result<i64> {
@@ -310,7 +309,6 @@ pub fn add_config_version(
         tags,
         created_at: Utc::now().naive_utc(),
         description,
-        change_reason,
     };
     diesel::insert_into(config_versions)
         .values(&config_version)

crates/superposition_types/migrations/2025-02-11-100518_remove_description_config_version/down.sql

@@ -0,0 +1,3 @@
+-- This file should undo anything in `up.sql`
+ALTER TABLE public.config_versions
+ADD COLUMN description NOT NULL default '';

crates/superposition_types/migrations/2025-02-11-100518_remove_description_config_version/up.sql

@@ -0,0 +1,3 @@
+-- Your SQL goes here
+ALTER TABLE public.config_versions
+DROP COLUMN description;

crates/superposition_types/src/api.rs

@@ -1 +1,2 @@
+pub mod function;
 pub mod workspace;

crates/superposition_types/src/api/function.rs

@@ -0,0 +1,36 @@
+use serde::{Deserialize, Deserializer};
+use serde_json::Value;
+
+#[derive(Debug, Clone)]
+pub enum FunctionNameEnum {
+    Name(String),
+    Remove,
+}
+
+impl<'de> Deserialize<'de> for FunctionNameEnum {
+    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
+    where
+        D: Deserializer<'de>,
+    {
+        let map: Value = Deserialize::deserialize(deserializer)?;
+        match map {
+            Value::String(func_name) => Ok(Self::Name(func_name)),
+            Value::Null => Ok(Self::Remove),
+            _ => {
+                log::error!("Expected a string or null literal as the function name.");
+                Err(serde::de::Error::custom(
+                    "Expected a string or null literal as the function name.",
+                ))
+            }
+        }
+    }
+}
+
+impl FunctionNameEnum {
+    pub fn to_option(&self) -> Option<String> {
+        match self {
+            Self::Name(name) => Some(name.to_owned()),
+            Self::Remove => None,
+        }
+    }
+}

crates/superposition_types/src/config.rs

@@ -1,7 +1,6 @@
 use std::collections::{HashMap, HashSet};
 
 use derive_more::{AsRef, Deref, DerefMut, Into};
-// use diesel::{deserialize::{self, FromSql}, pg::{Pg, PgValue}, serialize::{self, Output, ToSql}};
 #[cfg(feature = "diesel_derives")]
 use diesel::{
     deserialize::{FromSql, FromSqlRow, Result as DResult},
@@ -266,40 +265,6 @@ impl ToSql<Integer, Pg> for Position {
     }
 }
 
-#[derive(Debug, Clone)]
-pub enum FunctionNameEnum {
-    Name(String),
-    Remove,
-}
-
-impl<'de> Deserialize<'de> for FunctionNameEnum {
-    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
-    where
-        D: Deserializer<'de>,
-    {
-        let map: Value = Deserialize::deserialize(deserializer)?;
-        match map {
-            Value::String(func_name) => Ok(Self::Name(func_name)),
-            Value::Null => Ok(Self::Remove),
-            _ => {
-                log::error!("Expected a string or null literal as the function name.");
-                Err(serde::de::Error::custom(
-                    "Expected a string or null literal as the function name.",
-                ))
-            }
-        }
-    }
-}
-
-impl FunctionNameEnum {
-    pub fn to_option(&self) -> Option<String> {
-        match self {
-            Self::Name(name) => Some(name.to_owned()),
-            Self::Remove => None,
-        }
-    }
-}
-
 #[cfg(test)]
 pub(crate) mod tests {
     use std::collections::{HashMap, HashSet};

crates/superposition_types/src/database/models/cac.rs

@@ -139,7 +139,6 @@ pub struct ConfigVersion {
     pub tags: Option<Vec<String>>,
     pub created_at: NaiveDateTime,
     pub description: String,
-    pub change_reason: String,
 }
 
 #[derive(Serialize, Deserialize, Clone, Debug)]

crates/superposition_types/src/database/schema.rs

@@ -14,7 +14,6 @@ diesel::table! {
         tags -> Nullable<Array<Varchar>>,
         created_at -> Timestamp,
         description -> Text,
-        change_reason -> Text,
     }
 }
 

crates/superposition_types/src/lib.rs

@@ -26,9 +26,7 @@ use regex::Regex;
 use serde::{Deserialize, Serialize};
 use webhook::WebhookConfig;
 
-pub use crate::config::{
-    Condition, Config, Context, FunctionNameEnum, Overrides, Position,
-};
+pub use crate::config::{Condition, Config, Context, Overrides, Position};
 pub use crate::contextual::Contextual;
 pub use crate::overridden::Overridden;