Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First, thank you for maintaining this repo 🙂
Context / Issue
Cancelling a test plan with CTRL-C does not work. The container is not stopped, and the plan continues until it ends. This is problematic, especially if you make a mistake in the plan and want it to stop right away to prevent catastrophic consequences 😆
Solution(s)
1/ First Solution
I tried replacing the following line in the entrypoint:
docker-jmeter/entrypoint.sh
Line 31 in 17e6c2b
by this:
; in order to pass down signals to JMeter. This unfortunately does not work. It looks like either JMeter is not properly handling SIGTINT signals, or that JMeter waits for its threads to complete before gracefully shutting down its process.
1/ Second Solution
This is what I retained in this PR, simply use tini to handle signals for us. This works.
Let me know what you think!
Thanks