Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SIGTINT signal #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexandre-abrioux
Copy link

@alexandre-abrioux alexandre-abrioux commented Jun 3, 2022

Hi! First, thank you for maintaining this repo 🙂

Context / Issue

Cancelling a test plan with CTRL-C does not work. The container is not stopped, and the plan continues until it ends. This is problematic, especially if you make a mistake in the plan and want it to stop right away to prevent catastrophic consequences 😆

Solution(s)

1/ First Solution

I tried replacing the following line in the entrypoint:

jmeter ${EXTRA_ARGS} $@

by this:

exec jmeter ${EXTRA_ARGS} $@

; in order to pass down signals to JMeter. This unfortunately does not work. It looks like either JMeter is not properly handling SIGTINT signals, or that JMeter waits for its threads to complete before gracefully shutting down its process.

1/ Second Solution

This is what I retained in this PR, simply use tini to handle signals for us. This works.

Let me know what you think!
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant