Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed if condition to get a True when expected. #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed if condition to get a True when expected. #1

wants to merge 1 commit into from

Conversation

asafpm
Copy link

@asafpm asafpm commented Mar 26, 2021

Indexing a byte array like data returns an int so when comparing equality with b'E' we always get False since the latter is a byte array. Indexing b'E' converts it to an int and fixes the comparison.

jeremitu added a commit to jeremitu/isfreader that referenced this pull request Aug 30, 2023
@jeremitu
Fixed parse error (see also justengel#1)
89b06f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asafpm