Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass keys to tag readers via opts. #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ccidral
Copy link

@ccidral ccidral commented Jun 4, 2022

Passes the key path to tag readers as :key-path in the opts map.

An example of use case for this is a #required tag reader that throws an exception when the value is nil. The key path needs to be included in the exception message to indicate which key in configuration is the offending key. So if we have a configuration like:

{:a {:b {:c #required #env "FOO"}}}

It would throw an exception with a message like Required key [:a :b :c].

@codecov-commenter
Copy link

Codecov Report

Merging #103 (5108c67) into master (743e9bc) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   79.13%   79.41%   +0.27%     
==========================================
  Files           4        4              
  Lines         369      374       +5     
  Branches       17       17              
==========================================
+ Hits          292      297       +5     
  Misses         60       60              
  Partials       17       17              
Impacted Files Coverage Δ
src/aero/core.cljc 75.00% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 743e9bc...5108c67. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants