Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr meggermo #39

Closed
wants to merge 2 commits into from
Closed

Pr meggermo #39

wants to merge 2 commits into from

Conversation

meggermo
Copy link

@meggermo meggermo commented Jan 5, 2019

Following the yada manual I ran into some issues:

  1. According to paragraph 2.1 I should cd into edge/app, but there is no such directory. I figured out it should be edge/main.
  2. I tried starting the dev repl as described in 2.2 from the main sub directory but the repl failed to start.

I managed to fix the startup issues, so now the dev repl starts upp and I can successfully access localhost:3000. The commit messages describe what failed and what I did to resolve them.

After cloning the edge repo and cd-ing into the "main" directory
I ran into the following issue when trying to start the app
$> clojure -A:dev:build:dev/rebel
Exception in thread "main" java.io.FileNotFoundException: Could not
locate edge/rebel/main__init.class or edge/rebel/main.clj on classpath.

I fixed it by adding the extra local dep edge.rebel.main to the
:dev/rebel alias.
When I want to start the dev system I run into the following issue:

[Edge] Now enter (go) to start the dev system
dev=> (go)
CompilerException java.io.FileNotFoundException: Could not locate
nrepl/server__init.class or nrepl/server.clj on classpath.,
compiling:(figwheel_sidecar/components/nrepl_server.clj:6:1)

I was able to fix it by upgrading to the latest released version
of figwheel.
@SevereOverfl0w
Copy link
Contributor

See: juxt/yada#247

edge/main will be removed in a future release, it is currently deprecated. It's not mentioned in any top-level documentation any more. It needs a note in the README really.

I would recommend using ../bin/rebel instead of bin/repl. It's an improved version.

@meggermo
Copy link
Author

Ok, if it's deprecated then my PR has not much value, I'll close it.
I suppose the yada documentation will be updated soon?

@meggermo meggermo closed this Jan 12, 2019
@meggermo meggermo deleted the pr-meggermo branch January 12, 2019 12:19
@SevereOverfl0w
Copy link
Contributor

It's on the near-term roadmap, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants