Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nx #516

Merged
merged 12 commits into from
Feb 2, 2024
Merged

Upgrade nx #516

merged 12 commits into from
Feb 2, 2024

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented Jan 31, 2024

Upgraded NX to latest version and fixed emerging issues

  • NX migration via nx migrate latest and nx migrate --run-migrations. I didn't check in the migrations.json file
  • Linter seems to have slightly changed, so I fixed it all required places
  • Fixed webpack configurations (missing config file not added by migration)
  • Remove conflicting linter rules from monaco-editor. The optimal way would be to remove the conflict, but we don't write much react anyway, so I'd just remove the jvalue eslint as a workaround...

Open Issues

  • the docusaurus plugin for nx is outdated and still references old @nrwl packages - not fixable right now

@georg-schwarz georg-schwarz requested a review from joluj January 31, 2024 14:03
Copy link
Contributor

@joluj joluj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some comments I'd rather still have included.

NX supports reading JSON files with comments but they get stripped when updating (See nrwl/nx#4244 (comment))

There is also a workaround, I'm not sure if I like it though :D

@georg-schwarz georg-schwarz changed the title WIP: Upgrade nx Upgrade nx Feb 2, 2024
@georg-schwarz georg-schwarz merged commit ff93966 into main Feb 2, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the upgrade-nx branch February 2, 2024 08:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants