Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Import Cycle in type-inference.ts #553

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Remove Import Cycle in type-inference.ts #553

merged 3 commits into from
Apr 18, 2024

Conversation

georg-schwarz
Copy link
Member

@georg-schwarz georg-schwarz commented Apr 18, 2024 •
edited
Loading

Removes the last dependency cycles indicated by the eslint no-cycle rule 🥳

@georg-schwarz georg-schwarz requested a review from rhazn April 18, 2024 11:41
rhazn
rhazn approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@rhazn rhazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick, good job. Left a tiny nitpick comment but feel free to merge however you decide on that without a new review.

@georg-schwarz georg-schwarz merged commit 2326441 into main Apr 18, 2024
3 checks passed
@georg-schwarz georg-schwarz deleted the import-cycle-evaluate-expression branch April 18, 2024 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhazn rhazn rhazn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georg-schwarz @rhazn