Skip to content

Commit

Permalink
feat: update container versioning (#4)
Browse files Browse the repository at this point in the history
* ci: update versioning format

* update todo items
  • Loading branch information
jveldboom authored Mar 13, 2023
1 parent 64433e8 commit 6bc4c74
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
12 changes: 1 addition & 11 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
run: |
docker build . \
--tag ghcr.io/${GITHUB_REPOSITORY}:${{ steps.version.outputs.version }} \
--tag ghcr.io/${GITHUB_REPOSITORY}:${{ steps.version.outputs.major }} \
--tag ghcr.io/${GITHUB_REPOSITORY}:latest
docker push --all-tags ghcr.io/${GITHUB_REPOSITORY}
Expand All @@ -40,15 +39,6 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
run: |
gh release create "${{ steps.version.outputs.version-with-prefix }}" \
gh release create "${{ steps.version.outputs.version }}" \
--generate-notes \
--target "${{ github.sha }}"
- name: Update Major Tag
env:
MAJOR: ${{ steps.version.outputs.major }}
run: |
git tag -d "${MAJOR}" || true
git push origin ":refs/tags/${MAJOR}"
git tag "${MAJOR}" "${GITHUB_SHA}"
git push origin "${MAJOR}"
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ docker run --rm -v $(pwd):/tmp primitive -i imgs/color-smoke.jpg -o out.gif -n 5
![animated gif](imgs/color-smoke.gif)

## TODO
- [ ] Publish image to container registry to prevent users from having to build image
- [ ] Create GitHub Actions workflow to publish container image
- [ ] Automation container versioning
- [x] Publish image to container registry to prevent users from having to build image
- [x] Create GitHub Actions workflow to publish container image
- [x] Automation container versioning
- [ ] Add PR tests to validate container can build, run and output a valid image

0 comments on commit 6bc4c74

Please sign in to comment.