Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont call sudo from the scripts. #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dont call sudo from the scripts. #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bin/create-java-perf-map.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
set -e
#set -x

if [[ $EUID -ne 0 ]]; then
echo "This script must be run as root" 1>&2
exit 1
fi

CUR_DIR=`pwd`
PID=$1
OPTIONS=$2
Expand All @@ -17,6 +22,6 @@ fi
[ -d $JAVA_HOME ] || JAVA_HOME=/etc/alternatives/java_sdk
[ -d $JAVA_HOME ] || (echo "JAVA_HOME directory at '$JAVA_HOME' does not exist." && false)

sudo rm $PERF_MAP_FILE -f
rm $PERF_MAP_FILE -f
(cd $PERF_MAP_DIR/out && java -cp $ATTACH_JAR_PATH:$JAVA_HOME/lib/tools.jar net.virtualvoid.perf.AttachOnce $PID $OPTIONS)
sudo chown root:root $PERF_MAP_FILE
chown root:root $PERF_MAP_FILE
7 changes: 6 additions & 1 deletion bin/perf-java-flames
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
set -e
#set -x

if [[ $EUID -ne 0 ]]; then
echo "This script must be run as root" 1>&2
exit 1
fi

PID=$1

if [ -z $PERF_JAVA_TMP ]; then
Expand Down Expand Up @@ -30,6 +35,6 @@ if [ -z $PERF_FLAME_OUTPUT ]; then
fi

$PERF_MAP_DIR/bin/perf-java-record-stack $*
sudo perf script -i $PERF_DATA_FILE > $STACKS
perf script -i $PERF_DATA_FILE > $STACKS
$FLAMEGRAPH_DIR/stackcollapse-perf.pl $STACKS | tee $COLLAPSED | $FLAMEGRAPH_DIR/flamegraph.pl --color=java > $PERF_FLAME_OUTPUT
echo "Flame graph SVG written to PERF_FLAME_OUTPUT='`readlink -f $PERF_FLAME_OUTPUT`'."
7 changes: 6 additions & 1 deletion bin/perf-java-record-stack
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
set -e
#set -x

if [[ $EUID -ne 0 ]]; then
echo "This script must be run as root" 1>&2
exit 1
fi

PERF_MAP_DIR=$(dirname $(readlink -f $0))/..
PID=$1

Expand All @@ -22,5 +27,5 @@ if [ -z $PERF_DATA_FILE ]; then
fi

echo "Recording events for $PERF_RECORD_SECONDS seconds (adapt by setting PERF_RECORD_SECONDS)"
sudo perf record -F $PERF_RECORD_FREQ -o $PERF_DATA_FILE -g -p $* -- sleep $PERF_RECORD_SECONDS
perf record -F $PERF_RECORD_FREQ -o $PERF_DATA_FILE -g -p $* -- sleep $PERF_RECORD_SECONDS
$PERF_MAP_DIR/bin/create-java-perf-map.sh $PID $PERF_MAP_OPTIONS
7 changes: 6 additions & 1 deletion bin/perf-java-report-stack
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
set -e
#set -x

if [[ $EUID -ne 0 ]]; then
echo "This script must be run as root" 1>&2
exit 1
fi

PID=$1
PERF_MAP_DIR=$(dirname $(readlink -f $0))/..

Expand All @@ -14,4 +19,4 @@ if [ -z $PERF_DATA_FILE ]; then
fi

$PERF_MAP_DIR/bin/perf-java-record-stack $*
sudo perf report -i $PERF_DATA_FILE
perf report -i $PERF_DATA_FILE
7 changes: 6 additions & 1 deletion bin/perf-java-top
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@
set -e
#set -x

if [[ $EUID -ne 0 ]]; then
echo "This script must be run as root" 1>&2
exit 1
fi

PERF_MAP_DIR=$(dirname $(readlink -f $0))/..

PID=$1
$PERF_MAP_DIR/bin/create-java-perf-map.sh $PID $PERF_MAP_OPTIONS
sudo perf top -p $*
perf top -p $*