Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementation of drag & drop (continued) #324

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

PwtKCL
Copy link
Collaborator

@PwtKCL PwtKCL commented Nov 27, 2024

In this PR, I've fixed a bug in the new implementation of the drag & drop that could cause frames to be moved in an illegal position.
It also contains the feature request of #257

@PwtKCL PwtKCL requested a review from neilccbrown November 27, 2024 17:35
@PwtKCL PwtKCL closed this Nov 28, 2024
@PwtKCL PwtKCL reopened this Nov 28, 2024
@neilccbrown
Copy link
Collaborator

Looks fine to merge, so I will do so. What's the replacement for the draggable group logic? I was using that in the new OOP stuff but I guess I need to make a change in a different part of the code now (e.g. class frames should only allow comments and functions)?

@neilccbrown neilccbrown merged commit ffeef8e into k-pet-group:main Nov 28, 2024
0 of 2 checks passed
@PwtKCL
Copy link
Collaborator Author

PwtKCL commented Nov 29, 2024

Looks fine to merge, so I will do so. What's the replacement for the draggable group logic? I was using that in the new OOP stuff but I guess I need to make a change in a different part of the code now (e.g. class frames should only allow comments and functions)?

There is no replacement as such. The groups were used as one layer for the checks of drag and drop - the other layer is a programmatic check against what frames are allowed at a given position. We can check together where in the code if needed;
Regarding the draggable group, there is no replacement because 1) the second layer of checking suffices and 2) if you see the commits of that PR, we seemed to only use the "all" group in the method I had deleted (...!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants