Add autocomplete support to the canvas graphics module #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aphics-autocomplete
…Strype's libraries because it couldn't load the internal libraries.
…aspects: - We need to load graphics.py to process it so I use webpack's support for loading text files at import-time. - Then we extract types from this file (added to the file in this commit) in the format TigerPython expects. And that's all we need to do. Then we have support in the autocomplete for the graphics types.
…ocomplete' into canvas-graphics
|
Code-wise I think the branch can be merged. There is one test failing that seems unrelated to the new tests added, so it shouldn't be too complex to sort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff for graphics.py seems to be quite screwed up; it shows me removing a bunch of code and re-adding it but really I just inserted some bits in the middle. The overall aim of this PR is to add code completion support to the canvas-graphics branch, based on the recent switch to TigerPython autocomplete in the main branch. We add some special type annotations in comments, then we have some code to extract these annotations and feed them to TigerPython, so for example it knows that load_image returns an EditableImage. We only need the annotations for return types, not parameters, as we don't need those for autocomplete. The new raw-loader library lets us load the .py files directly in Typescript.