Skip to content
Pull Request Validation

Add and fix golangci issues #4

Sign in to view logs

Add and fix golangci issues

Add and fix golangci issues #4

Triggered via pull request July 17, 2023 16:08
@ekarlsoekarlso
synchronize #41
ekarlso:golang-ci
Status Failure
Total duration 1m 59s
Artifacts –

pr.yaml

on: pull_request
Matrix: validate
Fit to window
Zoom out
Zoom in

Annotations

12 errors
Validate lint: bootstrap/controllers/kthreesconfig_controller.go#L215
(*KThreesConfigReconciler).joinControlplane - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate lint: bootstrap/controllers/kthreesconfig_controller.go#L276
(*KThreesConfigReconciler).joinWorker - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate lint: controlplane/controllers/kthreescontrolplane_controller.go#L602
(*KThreesControlPlaneReconciler).reconcileControlPlaneConditions - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate lint
Process completed with exit code 2.
Validate test-controlplane: bootstrap/controllers/kthreesconfig_controller.go#L215
(*KThreesConfigReconciler).joinControlplane - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate test-controlplane: bootstrap/controllers/kthreesconfig_controller.go#L276
(*KThreesConfigReconciler).joinWorker - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate test-controlplane: controlplane/controllers/kthreescontrolplane_controller.go#L602
(*KThreesControlPlaneReconciler).reconcileControlPlaneConditions - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate test-controlplane
Process completed with exit code 2.
Validate test-bootstrap: controlplane/controllers/kthreescontrolplane_controller.go#L602
(*KThreesControlPlaneReconciler).reconcileControlPlaneConditions - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate test-bootstrap: bootstrap/controllers/kthreesconfig_controller.go#L215
(*KThreesConfigReconciler).joinControlplane - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate test-bootstrap: bootstrap/controllers/kthreesconfig_controller.go#L276
(*KThreesConfigReconciler).joinWorker - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
Validate test-bootstrap
Process completed with exit code 2.