Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add Windows smoke test #11721

Closed
wants to merge 16 commits into from
Closed

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 6, 2025

Proposed Changes

Add Windows smoke test to GH CI

Types of Changes

test

Verification

Check CI

Testing

yes

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <[email protected]>
Netpol startup is skipped with a warning on linux if ipset support is missing, we should do the same on windows

Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the gh-windows-smoke branch 2 times, most recently from 4aedd47 to 36d38c4 Compare February 6, 2025 23:15
Signed-off-by: Brad Davidson <[email protected]>
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 23.63636% with 42 lines in your changes missing coverage. Please review.

Project coverage is 46.70%. Comparing base (85b3775) to head (2f0fb53).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/permissions/permissions_windows.go 0.00% 30 Missing ⚠️
pkg/cli/agent/agent.go 25.00% 2 Missing and 1 partial ⚠️
pkg/cli/server/server.go 25.00% 2 Missing and 1 partial ⚠️
pkg/util/permissions/permissions_others.go 40.00% 2 Missing and 1 partial ⚠️
pkg/agent/netpol/netpol_windows.go 0.00% 2 Missing ⚠️
pkg/agent/containerd/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11721      +/-   ##
==========================================
- Coverage   49.61%   46.70%   -2.91%     
==========================================
  Files         186      206      +20     
  Lines       19461    19483      +22     
==========================================
- Hits         9655     9099     -556     
- Misses       8410     9056     +646     
+ Partials     1396     1328      -68     
Flag Coverage Δ
e2etests 40.28% <33.33%> (-3.78%) ⬇️
inttests 34.99% <27.77%> (+<0.01%) ⬆️
unittests 16.29% <12.72%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant