Fix wildcard with embbeded registry test #9649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor Savian <[email protected]> Signed-off-by: Brad Davidson <[email protected]>
dereknola
approved these changes
Mar 5, 2024
Merged
vitorsavian
approved these changes
Mar 5, 2024
|
vagrant e2e flaked; merging to fix unit tests |
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Thanks @vitorsavian
Fix test broken by combined changes from #9599 and #9556
One PR added tests, another PR changed the logic; the combination of the two was not tested until both were merged to master.
Types of Changes
test
Verification
check CI
Testing
yes
Linked Issues
User-Facing Change
Further Comments