Skip to content

Commit

Permalink
Fix release workflow
Browse files Browse the repository at this point in the history
- remove "latest" image tage from docker meta
- remove use of IMAGE_NAME in manifest creation as
  docker meta tag is the full image name

Signed-off-by: adrianc <[email protected]>
  • Loading branch information
adrianchiris committed Nov 29, 2023
1 parent 75f2f5e commit 5de2d3a
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/image-push-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ jobs:
uses: docker/metadata-action@v4
with:
images: ${{ env.IMAGE_NAME }}
flavor: |
latest=false
tags: |
type=ref,event=tag
Expand All @@ -41,7 +43,6 @@ jobs:
platforms: linux/amd64
tags: |
${{ steps.docker_meta.outputs.tags }}-amd64
${{ steps.docker_meta.outputs.tags }}:${{ github.sha }}
file: ./Dockerfile

build-and-push-arm64-sriov-cni:
Expand All @@ -66,6 +67,8 @@ jobs:
uses: docker/metadata-action@v4
with:
images: ${{ env.IMAGE_NAME }}
flavor: |
latest=false
tags: |
type=ref,event=tag
Expand Down Expand Up @@ -101,6 +104,8 @@ jobs:
uses: docker/metadata-action@v4
with:
images: ${{ env.IMAGE_NAME }}
flavor: |
latest=false
tags: |
type=ref,event=tag
Expand All @@ -126,6 +131,8 @@ jobs:
uses: docker/metadata-action@v4
with:
images: ${{ env.IMAGE_NAME }}
flavor: |
latest=false
tags: |
type=ref,event=tag
Expand All @@ -138,7 +145,7 @@ jobs:

- name: Create manifest for multi-arch images
run: |
docker buildx imagetools create -t ${{ env.IMAGE_NAME }}:${{ steps.docker_meta.outputs.tags }} \
${{ env.IMAGE_NAME }}:${{ steps.docker_meta.outputs.tags }}-amd64 \
${{ env.IMAGE_NAME }}:${{ steps.docker_meta.outputs.tags }}-arm64 \
${{ env.IMAGE_NAME }}:${{ steps.docker_meta.outputs.tags }}-ppc64le
docker buildx imagetools create -t ${{ steps.docker_meta.outputs.tags }} \
${{ steps.docker_meta.outputs.tags }}-amd64 \
${{ steps.docker_meta.outputs.tags }}-arm64 \
${{ steps.docker_meta.outputs.tags }}-ppc64le

0 comments on commit 5de2d3a

Please sign in to comment.