-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sriov-cni build is not idempotent #263
Comments
The problems comes from a dependency that has a file with a whitespace We can fix this by bumping the dependency, but I think it would be cleaner to simplify the build rule by removing the |
I know, I've proposed fix there. It is merged but they do not have official version tag with this fix yet. Yes, if that dependency is not needed any longer for sriov-cni then the removal will be better. When this fix will be ready? When can we expect new version with recent fixes? |
I think this will not be an easy fix, as |
Can you please fix this issue by removing that dependency as proposed above? We are still waiting for the fix. |
@zeeke Can you plase take this issue and resolve it? |
#305 solves the issue. |
When you run make second time then it fails:
make
Running gofmt...
Running golangci-lint...
make: *** No rule to make target '.gopath/pkg/mod/github.com/blizzy78/[email protected]/testdata/src/falsenegativechanrecv/chanrecv', needed by '/opt/cek/sriov-cni/build/sriov'. Stop.
What did you expect to happen?
It should pass
What are the minimal steps needed to reproduce the bug?
Run make and then run make again.
Anything else we need to know?
Issue is already fixed on upstream component blizzy78/varnamelen#26
Component Versions
The text was updated successfully, but these errors were encountered: