Makefile refactor

[adrianchiris]

• cleanup makefile
• update buildtest workflow
• ran go mod tidy, update go.mod

[adrianchiris]

similar to what was done : k8snetworkplumbingwg/sriov-network-device-plugin#579

[coveralls]

Pull Request Test Coverage Report for Build 10161049791

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 12 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-10.2%) to 41.345%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/utils/utils.go	12	44.23%

Totals
Change from base Build 10159026028:	-10.2%
Covered Lines:	535
Relevant Lines:	1294

---

💛 - Coveralls

[zeeke]

LGTM

I think this should solve also:

• sriov-cni build is not idempotent #263

[adrianchiris]

LGTM

I think this should solve also:

• sriov-cni build is not idempotent #263

yeap, running make build twice will not fail :)

regarding failed CI: i need to compile statically as before to not depend on libc in the system. (in container it uses different one)

[adrianchiris]

@zeeke can we merge this one?

[thom311]

.PHONY: all
all: fmt lint build test

The all target now also includes test. That seems undesirable to me.

In particular, because all is also the default target.

On my machine, make test fails due to lack of permissions. Maybe I am doing it wrong, and I should develop in a new rootless netns, where I have permissions or run make as root(??). But I'd rather not do that (do you?)

Compare to autotools projects, where make does not include make check.

I think either:

• just don't include test in all target, as before.
• add new target (check-and-build) that contains fmt lint build (but not test) and which is the new default target. Like

.PHONY: check-and-build
check-and-build: fmt lint build

.PHONY: all
all: check-and-build test

[SchSeba]

agree! here with @thom311

@thom311 can you please open a PR for that?