Delete ConfIFNames parameter #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlguerrero12
force-pushed
the
fixinterfacenamenumber
branch
from
f9e08ec
to
7fb054f
Compare
mlguerrero12
changed the title
Pull Request Test Coverage Report for Build 5177878515
💛 - Coveralls |
mlguerrero12
force-pushed
the
fixinterfacenamenumber
branch
from
7fb054f
to
4e6eab8
Compare
zeeke
reviewed
Jun 15, 2023
There was a problem hiding this comment.
Changes look good to me.
I'm not sure if this can break some backward compatibility: NetConf is serialized during cmdAdd and deserialized during cmdDel.
@SchSeba , @adrianchiris, @Eoghan1232 Do you have any comment about this?
|
thanks @zeeke for your comment. You made me realize that we don't need this parameter at all. The interface name is taken from the var args. I will delete it. And no, it won't break backwards compatibility for the above reason. |
mlguerrero12
force-pushed
the
fixinterfacenamenumber
branch
from
9919869
to
8c1fc7b
Compare
mlguerrero12
changed the title
Eoghan1232
approved these changes
Jun 20, 2023
This parameter is only used in a check that is not valid because only a single interface name is used by the plugin. Additionally, the func GetVFLinkNames was renamed to GetVFLinkName to reflect that a single name is returned. Signed-off-by: Marcelo Guerrero <[email protected]>
mlguerrero12
force-pushed
the
fixinterfacenamenumber
branch
from
8c1fc7b
to
b159972
Compare
adrianchiris
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is only used in a check that is not valid because only a single interface name is used by the plugin. Additionally, the func GetVFLinkNames was renamed to GetVFLinkName to reflect that a single name is returned.