Fix mac address verification #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchSeba
force-pushed
the
fix_mac_address_verification
branch
from
ca2734b
to
f18e51a
Compare
|
LGTM, @SchSeba can you add a short description in commit msg explaining why its needed ? |
|
LGTM |
|
There are some issues with mlnx CI should be fixed later today / tommorow. |
Without this commit there is a possible bug if the user request a mac address with upper case. The issue is that netlink lib will always return the hardware struct for mac address and it will always be lower case. So to be able and do a right equal check we convert the user provided mac address to lower case always Signed-off-by: Sebastian Sch <[email protected]>
SchSeba
force-pushed
the
fix_mac_address_verification
branch
from
f18e51a
to
f1d045a
Compare
|
@adrianchiris done |
|
/test-all |
|
Two LGTM merging. Thanks, folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix there was a problem with upper or lower case mac address