Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MAC address after renaming the interface #280

Merged
merged 1 commit into from
Oct 13, 2023

Commits on Oct 13, 2023

  1. Set MAC address after renaming the interface

    Setting the MAC address at the end of SetupVF reduces
    the chances of race conditions with tools that set MAC
    address asynchronously (i.e. iavf).
    
    This commit solve an issue with i40e driver where calling
    `SetVFEffectiveMAC` after `SetVFHardwareMAC` may produce
    a VF with no connectivity even if the last configuration step
    didn't produce any error:
    
    ```
    + ip link set dev ens1f0 vf 0 mac 20:04:0f:f1:88:A1   # No error
    + ip link set dev temp_71 address 20:04:0f:f1:88:A1   # Transient error
    RTNETLINK answers: Resource temporarily unavailable
    + ip link set dev temp_71 address 20:04:0f:f1:88:A1   # No error
    ```
    
    Note: this seems to be a kernel driver regression introduced near
    torvalds/linux@c34743d
    
    Signed-off-by: Andrea Panattoni <[email protected]>
    zeeke committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d572508 View commit details
    Browse the repository at this point in the history