Update configuration-reference.md in SRIOV DPDK config #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed example in documentation. It is referring to the old name of the plugin
SchSeba
approved these changes
Jul 23, 2024
Pull Request Test Coverage Report for Build 9990741263Details
💛 - Coveralls |
adrianchiris
approved these changes
Jul 23, 2024
adrianchiris
merged commit 3478b67
into
k8snetworkplumbingwg:master
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a look of the example, looks like the code block is referring to an old name of the plugin.
Even in the doc file, in line 8 appears the correct type:
type(string, required): "sriov"