Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't get pfname for virtio pci path #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JasinlikeEatingOrange
Copy link

Fixed issue with virtio driver by adding a conditional check for the virtio path under the PCI address, preventing errors when the pf name cannot be found. This ensures successful acquisition of vf resources.

Fixes #507

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comment. Not an expert of virtIO, but is there any chance to cover this change via unit tests? See utils_test.go

pkg/utils/utils.go Outdated Show resolved Hide resolved
pkg/utils/utils.go Outdated Show resolved Hide resolved
@JasinlikeEatingOrange JasinlikeEatingOrange force-pushed the dev/fix-get-pfname branch 6 times, most recently from 2e68d1e to c220256 Compare November 30, 2023 09:06
@JasinlikeEatingOrange
Copy link
Author

Left a few comment. Not an expert of virtIO, but is there any chance to cover this change via unit tests? See utils_test.go

sorry, i have modify the code and add test case, it passed . thx for review.

Fixed issue with virtio driver by adding a conditional check for the virtio path under the PCI address,
preventing errors when the pf name cannot be found. This ensures successful acquisition of vf resources.

Fixes k8snetworkplumbingwg#507

Signed-off-by: JasinlikeEatingOrange <[email protected]>
@SchSeba
Copy link
Collaborator

SchSeba commented Dec 5, 2023

/hold

@SchSeba
Copy link
Collaborator

SchSeba commented Aug 19, 2024

can I close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use usespace vdpa can't find the pfName because the net path is wrong
3 participants