Merge pull request #721 from k8up-io/chart-event-rbac

Regression: Add missing RBAC rule for events
k8up-io · Aug 15, 2022 · 88413f8 · 88413f8
2 parents 77047cb + 7972f2c
commit 88413f8
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 7 deletions.
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -20,7 +20,7 @@
   `bug`, `enhancement`, `documentation`, `change`, `breaking`, `dependency`
   as they show up in the changelog
 - [ ] PR contains the label `area:chart`
-- [ ] PR contains the chart label, e.g. `chart:appcat-service-s3`
+- [ ] PR contains the chart label, e.g. `chart:k8up`
 - [ ] Variables are documented in the values.yaml using the format required by [Helm-Docs](https://github.com/norwoodj/helm-docs#valuesyaml-metadata).
 - [ ] Chart Version bumped if immediate release after merging is planned
 - [ ] I have run `make chart-docs`

diff --git a/api/v1/groupversion_info.go b/api/v1/groupversion_info.go
@@ -2,8 +2,6 @@
 // +kubebuilder:object:generate=true
 // +groupName=k8up.io
 
-// +kubebuilder:rbac:groups=coordination.k8s.io,resources=leases,verbs=get;list;create;update
-
 package v1
 
 import (

diff --git a/charts/k8up/Chart.yaml b/charts/k8up/Chart.yaml
@@ -6,7 +6,7 @@ keywords:
   - backup
   - operator
   - restic
-version: 3.0.0
+version: 3.0.1
 sources:
   - https://github.com/k8up-io/k8up
 maintainers:

diff --git a/charts/k8up/README.md b/charts/k8up/README.md
@@ -1,6 +1,6 @@
 # k8up
 
-![Version: 3.0.0](https://img.shields.io/badge/Version-3.0.0-informational?style=flat-square)
+![Version: 3.0.1](https://img.shields.io/badge/Version-3.0.1-informational?style=flat-square)
 
 Kubernetes and OpenShift Backup Operator based on restic
 
@@ -13,7 +13,7 @@ helm repo add k8up-io https://k8up-io.github.io/k8up
 helm install k8up k8up-io/k8up
 ```
 ```bash
-kubectl apply -f https://github.com/k8up-io/k8up/releases/download/k8up-3.0.0/k8up-crd.yaml
+kubectl apply -f https://github.com/k8up-io/k8up/releases/download/k8up-3.0.1/k8up-crd.yaml
 ```
 
 <!---

diff --git a/charts/k8up/templates/operator-clusterrole.yaml b/charts/k8up/templates/operator-clusterrole.yaml
@@ -49,6 +49,13 @@ rules:
       - get
       - list
       - update
+  - apiGroups:
+      - ""
+    resources:
+      - events
+    verbs:
+      - create
+      - patch
   - apiGroups:
       - ""
     resources:

diff --git a/config/rbac/role.yaml b/config/rbac/role.yaml
@@ -47,6 +47,13 @@ rules:
   - get
   - list
   - update
+- apiGroups:
+  - ""
+  resources:
+  - events
+  verbs:
+  - create
+  - patch
 - apiGroups:
   - ""
   resources:

diff --git a/controllers/controller_setup.go b/controllers/controller_setup.go
@@ -5,6 +5,9 @@ import (
 	ctrl "sigs.k8s.io/controller-runtime"
 )
 
+// +kubebuilder:rbac:groups=coordination.k8s.io,resources=leases,verbs=get;list;create;update
+// +kubebuilder:rbac:groups=core,resources=events,verbs=create;patch
+
 // ReconcilerSetup is a common interface to configure reconcilers.
 type ReconcilerSetup interface {
 	SetupWithManager(mgr ctrl.Manager, l logr.Logger) error

diff --git a/docs/modules/ROOT/pages/explanations/release.adoc b/docs/modules/ROOT/pages/explanations/release.adoc
@@ -55,7 +55,7 @@ This process mostly relies on https://goreleaser.com/[GoReleaser].
 
 == Helm Chart Release
 
-Releasing a new version of a Helm chart requires pushing a **new Git tag**, following the SemVer schema with a **chart name prefix**, for example `appcat-service-s3-1.2.3`.
+Releasing a new version of a Helm chart requires pushing a **new Git tag**, following the SemVer schema with a **chart name prefix**, for example `k8up-3.2.1`.
 It's recommended to create a PR for each Helm chart change separately.
 After merging a PR for a Helm chart it's _not_ required to immediately release it.