isDirectory for symlinks isn't exactly safe..

kLabz · Apr 19, 2024 · 4605031 · 4605031
1 parent 154ee18
commit 4605031
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/build/download.hxb b/build/download.hxb
diff --git a/build/select.hxb b/build/select.hxb
diff --git a/src/Utils.hx b/src/Utils.hx
@@ -42,7 +42,8 @@ function getVersions():Array<String> {
 // TODO: windows vs symlinks
 function hasVersion(v:String):Bool {
 	final dir = Path.join([versionsDir, v]);
-	return FileSystem.isDirectory(dir);
+	return FileSystem.exists(dir);
+	// return FileSystem.isDirectory(dir);
 }
 
 function selectVersion(v:String, ?skipCheck:Bool = false):Void {
@@ -55,7 +56,8 @@ function selectVersion(v:String, ?skipCheck:Bool = false):Void {
 
 function selectRelease(r:String):Void {
 	final dir = Path.join([releasesDir, r]);
-	if (!FileSystem.isDirectory(dir)) throw 'Version $r is not installed';
+	if (!FileSystem.exists(dir)) throw 'Version $r is not installed';
+	// if (!FileSystem.isDirectory(dir)) throw 'Version $r is not installed';
 
 	unlinkCurrent();
 	link(dir);