Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

announce a successful +13 item #61

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

thmsndk
Copy link
Contributor

@thmsndk thmsndk commented Nov 14, 2023

This announces a successful +13 item on the server, and should also announce it to discord

image
image

Based upon the post in #suggestions
https://discord.com/channels/238332476743745536/1172948015170986034

@thmsndk thmsndk marked this pull request as ready for review November 14, 2023 22:26
@thmsndk
Copy link
Contributor Author

thmsndk commented Nov 14, 2023

🤔 Seems like i committed the if item.silent check too fast, and the workflow never ran again :/
Error seems to indicate that it did not like the ?? syntax

@NexusNull NexusNull self-assigned this Nov 14, 2023
@NexusNull NexusNull self-requested a review November 14, 2023 22:53
Copy link
Collaborator

@NexusNull NexusNull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NexusNull NexusNull removed their assignment Nov 14, 2023
@kaansoral kaansoral merged commit 7c6478b into kaansoral:main Nov 15, 2023
1 check passed
@thmsndk thmsndk deleted the feature/announce_plus13 branch May 8, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants