Update ruby and bundler version #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to get rid of a lot of deprecation messages
|
CI is failing due to bundle install and native extensions... The container setup works, rspec tests inside the container succeed. Updated the readme with new instructions. I want to keep this branch as is for now, to have as baseline while in a new branch I want to attempt an upgrade to Rails 6 |
because we removed 'activerecord-typedstore'
Upgrade rails to 6
Added redis initializer to disable the SSL connection, needed for Heroku
``` Unrecognized :enable_starttls_auto value "true"; expected true, false, or nil ```
This is needed now because the ubuntu-24.04 image does not contain the Heroku CLI anymore. See AkhileshNS/heroku-deploy#184
pascalw
force-pushed
the
update-heroku-stack
branch
from
61d4edf to
f88a366
Compare
|
Since Heroku is force upgrading Redis tomorrow, which breaks the currently deployed version, I'm going to merge this branch and deploy it to production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Explain what changes inside the code, this can be as simple or complicated as you want as long as it's clear
Setup docker compose to upgrade to ruby 2.7.0, the lowest ruby compatible with Rails 7
Why
Explain why these things are changes. This explanation is for your colleagues and your future self.
We want to go through an upgrade path for a compatible heroku stack.
Step 1. (this PR) get app working with Ruby 2.7
Step 2. #79 Upgrade to rails 6 (IN PROGRESS)
Step 3. Upgrade to rails 7 (TODO)
Step 7. Upgrade to ruby 3.3 (TODO)
Code Review
Please consider the following checklist when reviewing this Pull Request.
More background and details here.