Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign UI #109

Merged
merged 67 commits into from
Oct 12, 2023
Merged

Redesign UI #109

merged 67 commits into from
Oct 12, 2023

Conversation

RoyAppeldoorn
Copy link
Contributor

@RoyAppeldoorn RoyAppeldoorn commented Aug 22, 2023 •
edited
Loading

What

It's time for a redesign of the kudo's front-end app, including replacing the semantic-ui component library with our own components to adhere to a company wide style.

Code Review

Please consider the following checklist when reviewing this Pull Request.
More background and details here.

  • Does the code actually solve the problem it was meant to solve?
  • Is the code covered by unit tests? Integration tests?
  • Does anything here need documentation? (Focus on why, not what.)
  • Does any of this code deal with privacy sensitive information or affects security? Ask an additional reviewer.
  • Is the code easy to understand and change in the future?
  • Is the same code or concept duplicated? Find a balance between DRYness and readability.
  • Does the code reasonably adhere to the Kabisa coding standards?
  • Be kind.

@sandercamp sandercamp self-requested a review August 29, 2023 07:14
@codeclimate
Copy link

codeclimate bot commented Aug 29, 2023

Code Climate has analyzed commit bd1abc0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.9% (-0.1% change).

View more on Code Climate.

sandercamp and others added 21 commits August 29, 2023 09:54
@sandercamp
Update ui-components and fix button story
14d553b
@sandercamp
Allow access to ui-components src code
be1d6d3
@sandercamp
Remove semantic ui elements from FeedPage
32d5007
@sandercamp
Overrule semantic-ui font
9a02dae
@sandercamp
Remove semantic-ui from notifications, settings, statistics and user …
cf2a10b 
…modules
@RoyAppeldoorn
Add react-select as a multiselect dropdown replacement
9bef3d1
@RoyAppeldoorn
Temporarely disable semantic ui css
3cbe0b0
@RoyAppeldoorn
Remove semantic-ui from choose-team and feed modules
0e474ad
@RoyAppeldoorn
Temporarely not showing the menu from @sandercamp/ui-components
8a862ab
@RoyAppeldoorn
Merge branch 'chore/update-styles' of github.com:kabisa/kudos-fronten…
6b2b370 
…d into chore/update-styles
@RoyAppeldoorn
Remove semantic-ui for login module
2280c1c
@sandercamp
Update BackButton, add Segment and Page components
3fedfff
@sandercamp
Fix merge issues
322e500
@sandercamp
Add spacing to reset password form
4be226c
@sandercamp
Update ui-components to 0.0.27
4756af6
@RoyAppeldoorn
Remove semantic-ui from manage-team module
6bc5e83
@sandercamp
Raw update of FeedPage styling
eb11662
@RoyAppeldoorn
Add header styles
c9afea0
@RoyAppeldoorn
Merge branch 'chore/update-styles' of github.com:kabisa/kudos-fronten…
9577437 
…d into chore/update-styles
@sandercamp
Fix grid layout and (temporarily) add segment box shadow
44594ca
@RoyAppeldoorn
Basic styling for manage team page
5f08037
RoyAppeldoorn and others added 24 commits September 14, 2023 08:40
@RoyAppeldoorn
Fix bug where the image modal pops up twice
abed60e
@RoyAppeldoorn
Reset kudo form after submit
67f6ab0
@RoyAppeldoorn
Convert style folder to css instead of scss
f0cbbc6
@RoyAppeldoorn
Redesign for a big part of the login module
acd3459
@RoyAppeldoorn
Reset select state on clear event
1414cf2
@RoyAppeldoorn
Add styling for finish forget password page
e6a738f
@RoyAppeldoorn
Fix bug where two toasts show instead of one
fe65914
@RoyAppeldoorn
Refetch data when performing an action
1bd28f7
@RoyAppeldoorn
Minor changes
157f351
@RoyAppeldoorn
Fix styling where the BackButton component is used
8e0f547
@RoyAppeldoorn
Remove unused React imports
ded07db
@marcianosr
Fix scss path error and TS error.
77d6938
@marcianosr
Fix dependency issues for tests
7fe448e
@RoyAppeldoorn
Configure jest
223e6db
@marcianosr
Upgrade yarn and allow tests to run again.
e5fcf9f
@marcianosr
Downgrade RTL
35e815d
@marcianosr
Skip all tests
76f1a12
@marcianosr
Comment out all tests
b98547a
@marcianosr
Include yarn berry file
9fd1b71
@marcianosr
Comment out twitter-moment.
9300c56
@RoyAppeldoorn
Use node_modules
b06c183
@RoyAppeldoorn
Replace backticks with single quote to fix git commando
2bbcb51
@RoyAppeldoorn
Fix linting errors
1043aca
@RoyAppeldoorn
Fix linting errors
eb24f7e
@RoyAppeldoorn RoyAppeldoorn marked this pull request as ready for review October 12, 2023 11:29
@RoyAppeldoorn RoyAppeldoorn merged commit de03086 into develop Oct 12, 2023
6 checks passed
@sandercamp sandercamp deleted the chore/update-styles branch November 24, 2023 12:45
@sandercamp sandercamp restored the chore/update-styles branch November 24, 2023 12:45
@matthijsgroen matthijsgroen deleted the chore/update-styles branch May 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandercamp sandercamp Awaiting requested review from sandercamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoyAppeldoorn @sandercamp @marcianosr