Skip to content

Commit

Permalink
Making it so it can be empty, default or different from the default
Browse files Browse the repository at this point in the history
  • Loading branch information
echo-devnull committed May 12, 2021
1 parent c84cbd8 commit e876060
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ module "system" {
alert_env = var.alert_env
env = var.env
filter_str = var.filter_str
notification_channel = var.systems_notification ? var.notification_channel : ""

notification_channel = var.system_notification_channel_override == null ? var.notification_channel : var.system_notification_channel_override


service = var.service
bytes_sent_docs = "If you are monitoring Kafka’s bytes in/out metric, you are getting Kafka’s side of the story. To get a full picture of network usage on your host, you need to monitor host-level network throughput, especially if your Kafka brokers are hosting other network services. High network usage could be a symptom of degraded performance—if you are seeing high network use, correlating with TCP retransmissions and dropped packet errors could help in determining if the performance issue is network-related.\nhttps://www.datadoghq.com/blog/monitoring-kafka-performance-metrics"
bytes_received_docs = "If you are monitoring Kafka’s bytes in/out metric, you are getting Kafka’s side of the story. To get a full picture of network usage on your host, you need to monitor host-level network throughput, especially if your Kafka brokers are hosting other network services. High network usage could be a symptom of degraded performance—if you are seeing high network use, correlating with TCP retransmissions and dropped packet errors could help in determining if the performance issue is network-related.\nhttps://www.datadoghq.com/blog/monitoring-kafka-performance-metrics"
Expand Down
6 changes: 3 additions & 3 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ variable "locked" {
default = true
}

variable "systems_notification" {
type = bool
default = true
variable "system_notification_channel_override" {
type = string
default = null
}

0 comments on commit e876060

Please sign in to comment.