Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

Fix accessibility insight warnings #579

Merged
merged 6 commits into from
Sep 4, 2024
Merged

Fix accessibility insight warnings #579

merged 6 commits into from
Sep 4, 2024

Conversation

kachick
Copy link
Owner

@kachick kachick commented Sep 4, 2024

  • Add missing labels
  • Add comment for non li in ol problem
  • Apply high contrast color for revision link

Resolves GH-577

https://pagespeed.web.dev/analysis/https-mobu-elm--pr579-fix-insight-ui-7me2jcon-web-app/yekj4svu1i?form_factor=mobile

image

Still exist label, and another contrast issue

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Visit the preview URL for this PR (updated for commit 229732a):

https://mobu-elm--pr579-fix-insight-ui-7me2jcon.web.app

(expires Wed, 11 Sep 2024 17:51:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c3bd1c7e660dfd047316b813d1455fa3121557d6

@kachick
Copy link
Owner Author

kachick commented Sep 4, 2024

@kachick kachick changed the title Fix UI insight warnings Fix accessibility insight warnings Sep 4, 2024
@kachick kachick merged commit dd6b842 into main Sep 4, 2024
9 checks passed
@kachick kachick deleted the fix-insight-ui branch September 4, 2024 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights
1 participant