Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Send for Vad #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreytkachenko
Copy link

@andreytkachenko andreytkachenko commented Jul 16, 2020

It should be safe to implement Send for Vad since Vad does not contain any Rc analogs and other non-sendable types

It should be safe to implement `Send` for `Vad` since `Vad` does not contain any `Rc` analogs and other non-mendable types
@kaegi
Copy link
Owner

kaegi commented Jul 16, 2020

I think the question is also whether the underlying C structs are Send.

The relevant structures in the C-Code are

https://github.com/dpirch/libfvad/blob/fdf039bd6a8d201b27175dccf8d85c003c2cf252/src/fvad.c#L32
https://github.com/dpirch/libfvad/blob/fdf039bd6a8d201b27175dccf8d85c003c2cf252/src/vad/vad_core.h#L26
https://github.com/dpirch/libfvad/blob/master/src/signal_processing/signal_processing_library.h#L80

which are basically only composed of integers without any connection to multi-threading. So I think there probably is no problem. Do you want a new version with this change?

@andreytkachenko
Copy link
Author

Thanks for you reply. I think version bump to 0.4.1 would be okay.

@andreytkachenko
Copy link
Author

Hi! It would be great to have some resolution on that PR. Thank you.

@droundy
Copy link

droundy commented Apr 12, 2022

Any chance of getting this done?

@srikarm99
Copy link

Hey, is there any chance of doing it?
I actually need this feature as I am planning to use it in async context with a mutex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants