Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create connector 404 (#92) #136

Merged
merged 5 commits into from
Mar 7, 2024
+58 −19
Merged

Create connector 404 (#92) #136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce87157
Create connector 404 (#92)
Nilumilak Feb 12, 2024
81cb57c
Create connector 404 (#92)
Nilumilak Feb 19, 2024
d529c6a
Create connector 404 (#92)
Nilumilak Feb 21, 2024
ea3c2d4
Merge branch 'main' into bugfix/create_connector
Haarolean Mar 1, 2024
26e05ec
Merge branch 'main' into bugfix/create_connector
Haarolean Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions frontend/src/components/Connect/List/CreateConnectorButton.tsx
View file
Open in desktop

This file was deleted.

37 changes: 24 additions & 13 deletions frontend/src/components/Connect/List/ListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import React, { Suspense } from 'react';
import useAppParams from 'lib/hooks/useAppParams';
import { ClusterNameRoute } from 'lib/paths';
import { ClusterNameRoute, clusterConnectorNewRelativePath } from 'lib/paths';
import ClusterContext from 'components/contexts/ClusterContext';
import Search from 'components/common/Search/Search';
import * as Metrics from 'components/common/Metrics';
import PageHeading from 'components/common/PageHeading/PageHeading';
import Tooltip from 'components/common/Tooltip/Tooltip';
import { ControlPanelWrapper } from 'components/common/ControlPanel/ControlPanel.styled';
import PageLoader from 'components/common/PageLoader/PageLoader';
import { ConnectorState } from 'generated-sources';
import { ConnectorState, Action, ResourceType } from 'generated-sources';
import { useConnectors, useConnects } from 'lib/hooks/api/kafkaConnect';
import { ActionButton } from 'components/common/ActionComponent';

import CreateConnectorButton from './CreateConnectorButton';
import List from './List';

const ListPage: React.FC = () => {
Expand All @@ -34,16 +34,27 @@ const ListPage: React.FC = () => {
return (
<>
<PageHeading text="Connectors">
{!isReadOnly &&
(connects && connects.length > 0 ? (
<CreateConnectorButton />
) : (
<Tooltip
value={<CreateConnectorButton disabled />}
content="No connects available"
placement="left"
/>
))}
{!isReadOnly && (
Mgrdich marked this conversation as resolved.
Show resolved Hide resolved
<Tooltip
value={
<ActionButton
buttonType="primary"
buttonSize="M"
disabled={!connects.length}
to={clusterConnectorNewRelativePath}
permission={{
resource: ResourceType.CONNECT,
action: Action.CREATE,
}}
>
Create Connector
</ActionButton>
}
showTooltip={!connects.length}
content="No Connects available"
placement="left"
/>
)}
</PageHeading>
<Metrics.Wrapper>
<Metrics.Section>
Expand Down
10 changes: 8 additions & 2 deletions frontend/src/components/common/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,15 @@ interface TooltipProps {
value: React.ReactNode;
content: string;
placement?: Placement;
showTooltip?: boolean;
}

const Tooltip: React.FC<TooltipProps> = ({ value, content, placement }) => {
const Tooltip: React.FC<TooltipProps> = ({
value,
content,
placement,
showTooltip = true,
}) => {
const [open, setOpen] = useState(false);
const { x, y, refs, strategy, context } = useFloating({
open,
Expand All @@ -28,7 +34,7 @@ const Tooltip: React.FC<TooltipProps> = ({ value, content, placement }) => {
<div ref={refs.setReference} {...getReferenceProps()}>
<S.Wrapper>{value}</S.Wrapper>
</div>
{open && (
{showTooltip && open && (
<S.MessageTooltip
ref={refs.setFloating}
style={{
Expand Down
Loading