-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE: Chore: Upgrade java to 21 #628
Conversation
Hi @Haarolean, Here is another PR to bump versions of several components, trying to go to Java 21 another step to #490. I still haven't been able to run the smoke, regression or sanity tests on my Mac M1. I've managed to solve some issues around docker incompatibilities like |
Yeah I remember having issues with running e2e on m1 as well, mostly due to x86-based images in e2e compose. As an alternative, you can run them in your forked repo. |
I didn't know I could do that, do you have a link to explain it? |
I still can't make the e2e tests work locally. |
sorry I don't have any articles on this, the point is that you can fork the repo and run whatever changes you need even on modified workflows in the fork repo :) There will be some failing tasks (due to lack of set secrets) like release and e2e reports uploading, but that's not that important. |
oh, thanks much! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All workflows seem to be passing successfully on a fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution!
@sixdouglas hey, would you be able to fix current conflicts? I want to merge this next so we don't have any future conflicts here. I can take it from here if you don't have an opportunity to resolve the conflicts atm. |
- kafka client: 3.3.1 -> 3.8.0 - aspectj: 1.9.9.1 -> 1.9.21 Maven Plugins: - clean: 3.2.0 -> 3.4.0 - compile: 3.10.1 -> 3.13.0 - resources: 3.2.0 -> 3.3.1 - surefire: 3.1.2 -> 3.5.1 - openapi generator : 6.6.0 -> 7.9.0 - springdoc openapi webflux: 1.2.32 -> 1.8.0 - surefire: 3.2.3 -> 3.5.1 (for e2e tests) - surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests) # Conflicts: # api/Dockerfile # documentation/compose/e2e-tests.yaml # frontend/src/components/Brokers/Broker/Configs/lib/constants.ts # pom.xml
- kafka client: 3.3.1 -> 3.8.0 - aspectj: 1.9.9.1 -> 1.9.21 Maven Plugins: - clean: 3.2.0 -> 3.4.0 - compile: 3.10.1 -> 3.13.0 - resources: 3.2.0 -> 3.3.1 - surefire: 3.1.2 -> 3.5.1 - openapi generator : 6.6.0 -> 7.9.0 - springdoc openapi webflux: 1.2.32 -> 1.8.0 - surefire: 3.2.3 -> 3.5.1 (for e2e tests) - surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests)
- kafka client: 3.3.1 -> 3.8.0 - aspectj: 1.9.9.1 -> 1.9.21 - byte-buddy: 1.12.19 -> 1.14.19 - mockito: 5.11.0 -> 5.14.2 Maven Plugins: - clean: 3.2.0 -> 3.4.0 - compile: 3.10.1 -> 3.13.0 - resources: 3.2.0 -> 3.3.1 - surefire: 3.1.2 -> 3.5.1 - openapi generator : 6.6.0 -> 7.9.0 - springdoc openapi webflux: 1.2.32 -> 1.8.0 - surefire: 3.2.3 -> 3.5.1 (for e2e tests) - surefire-ng: 3.2.5 -> 3.5.1 (for e2e tests)
Hello @Haarolean |
@sixdouglas thank you for your contribution! |
Thank you for accepting my contribution |
Resolves #490
bump java version to 21
Maven Plugins:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)