Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Set default message polling mode #649

Merged
merged 3 commits into from
Nov 17, 2024

Conversation

wernerdv
Copy link
Contributor

@wernerdv wernerdv commented Nov 6, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
According to MessagesApi the mode argument (Messages polling mode) is optional, so a null value is possible.
However, the getTopicMessagesV2 method has a check for a non-null value for the mode argument.
The suggested solution is to set the default value to LATEST if mode is null.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@wernerdv wernerdv requested a review from a team as a code owner November 6, 2024 15:22
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 6, 2024
@wernerdv
Copy link
Contributor Author

wernerdv commented Nov 6, 2024

@Haarolean Hello, PTAL.

address review comments
@Haarolean Haarolean self-requested a review November 11, 2024 10:03
@germanosin germanosin self-requested a review November 11, 2024 14:09
@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt and removed status/triage/manual Manual triage in progress labels Nov 12, 2024
@Haarolean Haarolean added this to the 1.1 milestone Nov 17, 2024
@Haarolean Haarolean merged commit 8f9c634 into kafbat:main Nov 17, 2024
21 of 24 checks passed
@Haarolean
Copy link
Member

@wernerdv thanks!

@wernerdv wernerdv deleted the set_default_polling_mode branch November 17, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend Related to backend changes status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants