Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion between 162 currencies #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

utopiatopia
Copy link
Contributor

Fixes #153 in part. For those curious, here's the script I used.

@robinmetral
Copy link

Nice 😬 Out of curiosity, what are the downsides of adding this many new bangs to the file, besides freezing github.dev?

Screenshot from 2025-02-01 15-35-23

On top of my head, making the bangs.json file much larger might have side-effects for any consumers of the file, e.g. these "bangs everywhere" addons (thinking of yang right now)

@utopiatopia
Copy link
Contributor Author

It’s untenable if ISO/XE decides to remove or add currencies. You’d have edit a few hundred entries, or delete the XE block, then rerun my script.

I’ll also add, there’s better ways to implement this within Kagi. Despite this, this PR still exists as an implementation of your idea (if accepted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent currency conversion bangs?
2 participants