Print the EFI certs in the state command

[Itxaka]

Part of kairos-io/kairos#2484

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (d729cc7) to head (ff2252f).
Report is 3 commits behind head on main.

❗ Current head ff2252f differs from pull request most recent head d36d504. Consider uploading reports for the commit d36d504 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   52.89%   52.89%           
=======================================
  Files          16       16           
  Lines        1104     1104           
=======================================
  Hits          584      584           
  Misses        423      423           
  Partials       97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itxaka]

non-efi system:

efi system:

[jimmykarily]

This is still in the sdk. We should let the caller decide whether it cares about the errors or not. Otherwise, the caller has no way to get the error (e.g. to debug) without using replace in go.mod.

Since this is an exported function, feel free to ignore the error in the detectKairos function below (if the caller of that function wants to debug, it can call GetEfiCertsCommonNames() directly.)

[Itxaka]

I dont know about that. This returns the certs if it can get them, otherwise its an empty eficerts. There is no promise here of returning errors or not, debugging and such, this is mostly an shortcut to not have to do the same thing in the state when getting the names and such, so its a commodity that promises nothing else in the signature of the call.

For getting the actual errors, and the full certificates (not just a list of the common names) there is another function that actually returns an error.

Maybe this should not be public, or maybe I should just move all the mangling into the state instead....

[Itxaka]

updated, now its a commodity method in state just to clean up the actual stuff coming from the signatures

[jimmykarily]

Nice!