fix: Use a proper config in renderState() #1217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akloeckner
reviewed
Feb 25, 2025
src/main.js
Outdated
| @@ -291,14 +291,16 @@ class MiniGraphCard extends LitElement { | |||
| const state = this.getEntityState(id); | |||
| // use tooltip data for main state element, if tooltip is active | |||
| const { entity: tooltipEntity, value: tooltipValue } = this.tooltip; | |||
| const value = isPrimary && tooltipEntity !== undefined ? tooltipValue : state; | |||
| const entity = isPrimary && tooltipEntity !== undefined ? tooltipEntity : id; | |||
| const condition = isPrimary && tooltipEntity !== undefined; | |||
There was a problem hiding this comment.
Can we give a speaking name to the condition? E.g. isTooltip?
src/main.js
Outdated
| const condition = isPrimary && tooltipEntity !== undefined; | ||
| const value = condition ? tooltipValue : state; | ||
| const entity = condition ? tooltipEntity : id; | ||
| const entity_config = condition ? this.config.entities[entity] : entityConfig; |
There was a problem hiding this comment.
Isn't entityConfig = this.config.entities[id]?
Suggested change
| const entity_config = condition ? this.config.entities[entity] : entityConfig; | |
| const entity_config = this.config.entities[entity]; |
If we change this, we can possibly also get rid of the additional function argument? Bear in mind that it's used a few lines before already...
And for consistent style, I would then call the constant camelcased entityConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #698 (comment)