Feature/owntone group support #751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalkih
reviewed
May 9, 2023
| @@ -80,7 +81,7 @@ class MiniMediaPlayerGroupList extends LitElement { | |||
| @change=${this.handleGroupChange} | |||
| .item=${item} | |||
| .hass=${this.hass} | |||
| .checked=${itemId === entityId || this.group.includes(itemId)} | |||
| .checked=${(this.player.config.speaker_group.platform === PLATFORM.OWNTONE && this.hass.states[itemId].state !== "off") || itemId === entityId || this.group.includes(itemId)} | |||
There was a problem hiding this comment.
We should try to not have platform specific logic spread throughout components, let's handle that in the Media Player model class.
Also how does the owntone checked logic work?
Should all owntone entities that are not "off" be considered as grouped? that doesn't seem right to me?
|
Checked this out and seems to work fairly well for owntone users would love to see this merged if possible for others to enjoy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added owntone to the plattforms and changed the behahavior of the group to use on/off instead of join/unjoin for owntone.
Cheers,
Jan