feat(FEC-13540): allow passing entry id to start playing the playlist from #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianbenjamin
requested review from
JonathanTGold,
semarche-kaltura,
MosheMaorKaltura and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Jan 4, 2024
SivanA-Kaltura
previously approved these changes
Jan 4, 2024
|
@lianbenjamin the .idea and coverage files were added by mistake ? |
|
@SivanA-Kaltura were added when i merged from master into branch. |
JonathanTGold
suggested changes
Jan 23, 2024
semarche-kaltura
requested changes
Jan 23, 2024
There was a problem hiding this comment.
do we need all those .idea files?
There was a problem hiding this comment.
revert changes for demo page
| @@ -7,3 +7,5 @@ body { | |||
| width: 640px; | |||
| height: 360px; | |||
| } | |||
|
|
|||
| /*xs - 380 x 209*/ | |||
There was a problem hiding this comment.
no needed in code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Add the ability to pass an entryId, to playlist API, which the playlist will start playing from.
Resolves FEC-13540