feat(FEC-13944): share and embed plugin to take player ratio to embed code #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lianbenjamin
requested review from
MosheMaorKaltura,
semarche-kaltura and
SivanA-Kaltura
SivanA-Kaltura
previously approved these changes
May 26, 2024
SivanA-Kaltura
approved these changes
May 27, 2024
lianbenjamin
added a commit
to kaltura/playkit-js-share
that referenced
this pull request
May 27, 2024
… code (#46) ### Description of the Changes **enhancement** - change the default values of the embed template to `{width}` and `{height}` as placeholders - when getting the embed url, replace the placeholders with values from the uiconf data related PR: kaltura/kaltura-player-js#784 Solves FEC-13944 ### CheckLists - [ ] changes have been done against master branch, and PR does not conflict - [ ] new unit / functional tests have been added (whenever applicable) - [ ] test are passing in local environment - [ ] Travis tests are passing (or test results are not worse than on master branch :)) - [ ] Docs have been updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
enhancement
take
widthandheightfrom__kalturaplayerdata.uiConfDataand evaluate them on share config.Resolves FEC-13944