fix(ADA-1514): Incorrect focus order is observed when Related Files button is activated. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utton is activated.
Tzipi-kaltura
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Oct 10, 2024
SivanA-Kaltura
requested changes
Oct 10, 2024
SivanA-Kaltura
approved these changes
Oct 15, 2024
5 tasks
Tzipi-kaltura
added a commit
that referenced
this pull request
Nov 4, 2024
…utton is activated. (#76) Issue: when we have more than one attachment/caption the focus move to the last item and not the first Solution: shouldFocus is sent as true to downloadItem only if this is the first item in the caption/attachment list and not for all item (and of course also only if this is the first list in the overlay) improvement of #74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
When open the download plugin with tab key, focus move to the first element in the modal only if the displayFlavors config is enabled. in case of display only captions or attachment, focus move to the body and not not specific element.
Fix:
Add functionality to check if captions/attachment or flavors will be displayed first in the modal, then move the focus according to that and not only according isDefault value (that relevant only to diaplyFlavors and not the rest of the configuration)
Solves ADA-1514
CheckLists