Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ADA-1747): [BofA] Marketting - Avoid the use of implicit headings #81

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix(ADA-1747): [BofA] Marketting - Avoid the use of implicit headings #81

merged 1 commit into from
Dec 9, 2024

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Dec 8, 2024 •
edited
Loading

Description of the Changes

Change download div element to h2 element (accessibility requirement)

solves ADA-1747

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Tzipi-kaltura Tzipi-kaltura merged commit 968582f into master Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tzipi-kaltura @semarche-kaltura