Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(FEC-12774): update readme #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

doc(FEC-12774): update readme #131

wants to merge 1 commit into from

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Dec 21, 2022

Description of the Changes

FEC-12774

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

```javascript
// Default config
"kava": {
serviceUrl: '//analytics.kaltura.com/api_v3/index.php',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it commented ?
if this is a sample url just write serviceUrl: [serviceUrl] or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants