fix(FEC-13517): Wrong and inconsistent order of plugins (#61)

fix: Wrong and inconsistent order of plugins fix: Plugins buttons sometimes display with the wrong icon solves: FEC-13517 FEC-13517 Related Prs kaltura/playkit-js-ui-managers#51 kaltura/playkit-js-transcript#175 kaltura/playkit-js-share#38 kaltura/playkit-js-moderation#74 kaltura/playkit-js-playlist#53 kaltura/playkit-js-navigation#348 kaltura/playkit-js-info#90 kaltura/playkit-js-navigation#348 kaltura/playkit-js-downloads#39 kaltura/playkit-js-qna#334 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
kaltura · Jan 24, 2024 · 6fa24aa · 6fa24aa
1 parent 5daee98
commit 6fa24aa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -1,4 +1,4 @@
-import {Related} from './related';
+import {pluginName, Related} from './related';
 
 declare let __VERSION__: string;
 declare let __NAME__: string;
@@ -9,6 +9,4 @@ const NAME = __NAME__;
 export {Related as Plugin};
 export {VERSION, NAME};
 
-const pluginName = 'related';
-
 KalturaPlayer.core.registerPlugin(pluginName, Related);
diff --git a/src/related.tsx b/src/related.tsx
@@ -8,6 +8,8 @@ import {UpperBarManager, SidePanelsManager} from '@playkit-js/ui-managers';
 import {Icon, RelatedConfig} from 'types';
 import {RelatedInternalEvent} from 'event';
 
+export const pluginName = 'related';
+
 const PRESETS = ['Playback', 'Live'];
 
 /**
@@ -178,9 +180,14 @@ class Related extends KalturaPlayer.core.BasePlugin {
   addRelatedListComponents() {
     const {relatedManager} = this;
     if (this.iconId > 0 || !relatedManager.entries.length) return;
-
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+    // @ts-ignore
     this.iconId = this.upperBarManager.add({
-      label: 'Related',
+      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+      // @ts-ignore
+      displayName: 'Related',
+      ariaLabel: 'Related',
+      order: 60,
       svgIcon: {
         viewBox: '0 0 32 32',
         path: Icon.LIST_TOGGLE